-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-4392 - Initial changes for ODH AMD GPU docs #561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chtyler
force-pushed
the
ENG-4392-amd-gpus-docs
branch
from
January 9, 2025 13:28
06044ee
to
7355f4b
Compare
chtyler
force-pushed
the
ENG-4392-amd-gpus-docs
branch
2 times, most recently
from
January 20, 2025 15:23
5264ee9
to
bd012fa
Compare
chtyler
changed the title
DRAFT - Do not merge: ENG-4292 - Initial changes for ODH AMD GPU docs
DRAFT - ENG-4292 - Initial changes for ODH AMD GPU docs
Jan 20, 2025
aduquett
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, looks great overall!
aduquett
reviewed
Jan 20, 2025
jiridanek
reviewed
Jan 20, 2025
chtyler
changed the title
DRAFT - ENG-4292 - Initial changes for ODH AMD GPU docs
[DRAFT] - ENG-4292 - Initial changes for ODH AMD GPU docs
Jan 20, 2025
…everal modules and correct some formatting issues and content errors
chtyler
force-pushed
the
ENG-4392-amd-gpus-docs
branch
from
January 31, 2025 14:09
bd012fa
to
b8928c0
Compare
aduquett
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chtyler
changed the title
[DRAFT] - ENG-4292 - Initial changes for ODH AMD GPU docs
ENG-4292 - Initial changes for ODH AMD GPU docs
Jan 31, 2025
chtyler
changed the title
ENG-4292 - Initial changes for ODH AMD GPU docs
ENG-4392 - Initial changes for ODH AMD GPU docs
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are the changes to document the introduction of the AMD GPUs GA at 2.16.1 for ODH. AMD have provided all of the in-depth enablement instructions for deploying the AMD GPU Operator on RHOAI. Therefore, we link out to the AMD instructions where and when possible. In some areas, we have needed to add our own content.
How Has This Been Tested?
Merge criteria: