Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4392 - Initial changes for ODH AMD GPU docs #561

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

chtyler
Copy link
Contributor

@chtyler chtyler commented Nov 25, 2024

Description

These are the changes to document the introduction of the AMD GPUs GA at 2.16.1 for ODH. AMD have provided all of the in-depth enablement instructions for deploying the AMD GPU Operator on RHOAI. Therefore, we link out to the AMD instructions where and when possible. In some areas, we have needed to add our own content.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@chtyler chtyler force-pushed the ENG-4392-amd-gpus-docs branch from 06044ee to 7355f4b Compare January 9, 2025 13:28
@chtyler chtyler force-pushed the ENG-4392-amd-gpus-docs branch 2 times, most recently from 5264ee9 to bd012fa Compare January 20, 2025 15:23
@chtyler chtyler changed the title DRAFT - Do not merge: ENG-4292 - Initial changes for ODH AMD GPU docs DRAFT - ENG-4292 - Initial changes for ODH AMD GPU docs Jan 20, 2025
Copy link
Contributor

@aduquett aduquett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks great overall!

modules/about-base-training-images.adoc Outdated Show resolved Hide resolved
modules/amd-gpu-integration.adoc Outdated Show resolved Hide resolved
modules/amd-gpu-integration.adoc Outdated Show resolved Hide resolved
modules/enabling-amd-gpus.adoc Outdated Show resolved Hide resolved
modules/enabling-amd-gpus.adoc Outdated Show resolved Hide resolved
modules/overview-of-accelerators.adoc Outdated Show resolved Hide resolved
@chtyler chtyler marked this pull request as draft January 20, 2025 16:35
@chtyler chtyler changed the title DRAFT - ENG-4292 - Initial changes for ODH AMD GPU docs [DRAFT] - ENG-4292 - Initial changes for ODH AMD GPU docs Jan 20, 2025
@chtyler chtyler force-pushed the ENG-4392-amd-gpus-docs branch from bd012fa to b8928c0 Compare January 31, 2025 14:09
@chtyler chtyler marked this pull request as ready for review January 31, 2025 14:10
Copy link
Contributor

@aduquett aduquett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chtyler chtyler changed the title [DRAFT] - ENG-4292 - Initial changes for ODH AMD GPU docs ENG-4292 - Initial changes for ODH AMD GPU docs Jan 31, 2025
@chtyler chtyler merged commit 67c451e into opendatahub-io:main Jan 31, 2025
@chtyler chtyler changed the title ENG-4292 - Initial changes for ODH AMD GPU docs ENG-4392 - Initial changes for ODH AMD GPU docs Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants